Comment on attachment 549230
patch v2.2
Review of attachment 549230:
-----------------------------------------------------------------
r=me with the below comments fixed.
::: content/base/public/nsIContent.h
@@ +948,5 @@
> + * Determing language. Look at the nearest ancestor element that has a lang
> + * attribute in the XML namespace or is an HTML element and has a lang in
> + * no namespace attribute.
> + */
> + void GetLang(nsAString& aResult) {
Oh, I almost forgot about this! Make this a const method please?
::: layout/reftests/editor/338427-2.html
@@ +6,5 @@
> + editor.focus();
> + window.setTimeout(function() {
> + editor.blur();
> + document.documentElement.className = '';
> + }, 1000); // XXX: 0 timeout is not enought to trigger a focus event.
Change this to:
setTimeout(function() {
setTimeout(function() {
editor.blur();
document....
}, 0);
}, 0);
::: layout/reftests/editor/338427-3.html
@@ +7,5 @@
> + editor.focus();
> + window.setTimeout(function() {
> + editor.blur();
> + document.documentElement.className = '';
> + }, 1000); // XXX: 0 timeout is not enought to trigger a focus event.
Same thing here.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select language for spell check based on user input
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/303269/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
