Comment on attachment 548731 patch v2 Review of attachment 548731: -----------------------------------------------------------------
The patch looks very good, r=me on it with the comments below addressed. Thanks a lot for working on this! ::: editor/composer/src/nsEditorSpellCheck.cpp @@ +188,5 @@ > rv = mSpellChecker->SetDocument(tsDoc, PR_TRUE); > NS_ENSURE_SUCCESS(rv, rv); > > + // do not fail if UpdateCurrentDictionary fails because this method may > + // success later. Nit: succeed ::: layout/reftests/editor/338427-ref.html @@ +1,4 @@ > +<!DOCTYPE html> > +<html> > +<body> > + <textarea lang="testing-XX">strangeimpossibleword</textarea> Technically, the -ref file is the reference rendering, and the other file is the thing to be tested. So, these two files should probably be swapped. ::: layout/reftests/editor/reftest.list @@ +62,5 @@ > == 642800.html 642800-ref.html > == selection_visibility_after_reframe.html > selection_visibility_after_reframe-ref.html > != selection_visibility_after_reframe-2.html > selection_visibility_after_reframe-ref.html > == 672709.html 672709-ref.html > +== 338427.html 338427-ref.html Can you add another test here for the dynamic change case? You can put lang="en-US" on the textarea, then upon load change it to "testing-XX", then .focus() and .blur(). Also, can you please add equivalent tests for contenteditable? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/303269 Title: Automatically select language for spell check based on user input To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/303269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
