Created attachment 548933 patch v2.1 (In reply to comment #64) > Nit: succeed
fixed > Technically, the -ref file is the reference rendering, and the other file is > the thing to be tested. So, these two files should probably be swapped. fixed > Can you add another test here for the dynamic change case? You can put > lang="en-US" on the textarea, then upon load change it to "testing-XX", then > .focus() and .blur(). do you mean adding commented tests for bug #674685 ? > Also, can you please add equivalent tests for contenteditable? Fixed. This was slightly tricky because it looks like spellcheck="disable" is not supported on contenteditable. So, the reference document contains a non editable area. Then, in the test document, I must first focus the contenteditable, to update dictionary. Then, blur to compare with non editable reference document. But if I focus then blur, I don't capture a focus event in editor listener. Neither if I set a 0 or small timeout. So, I've set a 1000 timeout. I known this is fragile, but I didn't find a better solution. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/303269 Title: Automatically select language for spell check based on user input To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/303269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
