On Mon, Oct 22, 2012 at 09:09:46AM -0700, Stephen Warren wrote: > On 10/19/2012 11:54 PM, Allen Martin wrote: > > On Thu, Oct 18, 2012 at 04:25:58PM -0700, Stephen Warren wrote: > >> From: Stephen Warren <swar...@nvidia.com> > >> > >> Seaboard and Ventana are very similar boards, and so share the seaboard.c > >> board file. The one difference needed so far is detected at run-time by > >> calling machine_is_ventana(). This bloats the Ventana build with code > >> that is never used. Switch to detecting Ventana at compile time to remove > >> bloat. This shaves ~5K off the SPL size on Ventana, and makes the SPL fit > >> within the max size. > >> > >> Signed-off-by: Stephen Warren <swar...@nvidia.com> > >> --- > >> v2: New patch to replace modification of CONFIG_SYS_TEXT_BASE. > >> --- > >> board/nvidia/seaboard/seaboard.c | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/board/nvidia/seaboard/seaboard.c > >> b/board/nvidia/seaboard/seaboard.c > >> index 4e8a183..6dce57f 100644 > >> --- a/board/nvidia/seaboard/seaboard.c > >> +++ b/board/nvidia/seaboard/seaboard.c > >> @@ -35,6 +35,7 @@ > >> > >> /* TODO: Remove this code when the SPI switch is working */ > >> #ifndef CONFIG_SPI_UART_SWITCH > >> +#if CONFIG_MACH_TYPE != MACH_TYPE_VENTANA > > > > Why not roll this into the previous #ifdef intead of the back to back > > #ifdefs? > > I guess I could, although it's going to get line-wrapped anyway due to > length...
Just a nit, your call. Either way: Acked-by: Allen Martin <amar...@nvidia.com> And the whole series: Tested-by: Allen Martin <amar...@nvidia.com> -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
