Dear Łukasz Dałek, > On 23.09.2012 23:04, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 23.09.2012 22:52, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > >>>> On 23.09.2012 22:05, Marek Vasut wrote: > >>>>> Dear Łukasz Dałek, > >>>>> > >>>>>> On 23.09.2012 21:31, Marek Vasut wrote: > >>>>>>> Dear Łukasz Dałek, > >>>>>>> > >>>>>>>> On 23.09.2012 17:43, Marek Vasut wrote: > >>>>>>>>>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE; > >>>>>>>>>> + return 0; > >>>>>>>>>> +} > >>>>>>>>>> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h > >>>>>>>>>> new file mode 100644 > >>>>>>>>> > >>>>>>>>> Do you need this file at all? Can the udc_disconnect() not be put > >>>>>>>>> somewhere into usb.h ? > >>>>>>>> > >>>>>>>> Can I just move this declaration into h2200.c? > >>>>>>> > >>>>>>> extern ... ? No, checkpatch will scream and extern is prohibited > >>>>>>> for a good reason. > >>>>>> > >>>>>> So where should I put it? > >>>>> > >>>>> Isn't it a general call? some include/usb.h ? > >>>> > >>>> For old layer maybe it is. > >>>> > >>>> I'm not sure but include/usb.h is for device implementing usb host but > >>>> pxa can only be device. > >>> > >>> PXA can be both, actually u-boot is mostly about host. Just put it > >>> there. > >>> > >>>> Including usb.h generate error. > >>>> > >>>> I'm going to add sd card support and other functions, maybe leaving it > >>>> would be better idea? > >>> > >>> Why do you think usb.h is not a good place ? > >> > >> Because: > >> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ > >> > >> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ > >> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || > >> \ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) > >> || \ defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ > >> defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) > >> > >> ... > >> #else > >> #error USB Lowlevel not defined > >> #endif > >> > >> All of these definitions are usb host implementation (maybe OTG too) but > >> pxa cannot be host. > > > > PXA2xx is OHCI host with one OTG port. > > From pxa255 documentation: > "The UDC supports 16 endpoints and can operate half-duplex at a rate of > 12 Mbps (as a slave only, > not as a host or hub controller)." > > > what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC > > use the same driver? > > pxa27x_udc driver is using older layer which doesn't work with usb > ethernet driver. > > Btw. pxa27x can be host, pxa25x can't.
Can you update the new gadget driver to be compatible with pxa27x then ? > Łukasz Dałek Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
