Dear Łukasz Dałek, > On 23.09.2012 22:05, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 23.09.2012 21:31, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > >>>> On 23.09.2012 17:43, Marek Vasut wrote: > >>>>>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE; > >>>>>> + return 0; > >>>>>> +} > >>>>>> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h > >>>>>> new file mode 100644 > >>>>> > >>>>> Do you need this file at all? Can the udc_disconnect() not be put > >>>>> somewhere into usb.h ? > >>>> > >>>> Can I just move this declaration into h2200.c? > >>> > >>> extern ... ? No, checkpatch will scream and extern is prohibited for a > >>> good reason. > >> > >> So where should I put it? > > > > Isn't it a general call? some include/usb.h ? > > For old layer maybe it is. > > I'm not sure but include/usb.h is for device implementing usb host but > pxa can only be device.
PXA can be both, actually u-boot is mostly about host. Just put it there. > Including usb.h generate error. > > I'm going to add sd card support and other functions, maybe leaving it > would be better idea? Why do you think usb.h is not a good place ? > Łukasz Dałek Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
