Hi Philippe,
On Thu, Jun 28, 2012 at 5:36 PM, Philippe Reynes <trem...@yahoo.fr> wrote:
> Signed-off-by: Philippe Reynes <trem...@yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarr...@armadeus.org>
Here we have armadeus.org
> Signed-off-by: Nicolas Colombain <nicolas.colomb...@armadeus.com>
,and here it is armadeus.com. Which one is correct?
> ---
> board/armadeus/apf27/Makefile | 52 ++++++
> board/armadeus/apf27/apf27.c | 310
> ++++++++++++++++++++++++++++++++++
> board/armadeus/apf27/config.mk | 38 ++++
> board/armadeus/apf27/lowlevel_init.S | 275 ++++++++++++++++++++++++++++++
> boards.cfg | 1 +
You missed an entry to the MAINTAINERS file.
> +void
> +show_boot_progress(int status)
> +{
> +#ifdef CONFIG_SHOW_BOOT_PROGRESS
> +#endif
This ifdef seems to be useless at this location.
> --- /dev/null
> +++ b/board/armadeus/apf27/lowlevel_init.S
Can't this be converted into a C file instead?
Check board/hale/tt01/tt01.c, for example.
> +#include <config.h>
> +#include <version.h>
> +#include <asm/macro.h>
> +#include <asm/arch/imx-regs.h>
> +#include <generated/asm-offsets.h>
> +
> +
> +
> +
To many new lines here.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
