Am Freitag 11 Mai 2012, 21:25:27 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <1336671134-16342-4-git-send-email-mich...@walle.cc> you wrote: > > Signed-off-by: Michael Walle <mich...@walle.cc> > > How many boards will be using this code? Hopefully more boars will use this function in the future, instead of messing around with the variable names themselves.
> Eventually this should be made configurable? Given the above, i would keep it non-configurable if youre fine with that. > > > + sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index); > > This should generate a warning: too many arguments for format. Mh, nice catch. That was just copied from the eth_getenv_enetaddr_by_index() function. I'll fix all of them. -- michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot