Hi Timo, On Thu, 26 Apr 2012 17:37:31 +0300 Timo Ketola <t...@exertus.fi> wrote: ... > Thanks for the review. Everything else is clear, but... > > On 26.04.2012 14:51, Anatolij Gustschin wrote: > ... > >> +++ b/drivers/video/mx2fb.c > >> @@ -0,0 +1,92 @@ > > > > Please add Copyright info here. > ... > >> +++ b/include/mx2fb.h > ... > > Please consider Stefano's comment regarding copyright header. > > I'm a little lost here. The original work is this: > > http://www.imxdev.org/wiki/images/d/d0/U-boot-splash.tar.gz > > from here: > > http://www.imxdev.org/wiki/index.php?title=I.MX25_PDK_U-boot_SplashScreen > > There is also a u-boot.spec.in file in the package which says: > > License : GPL > Vendor : Freescale > Packager : MAD > > Now, can I really just edit the mx2fb.h copyright notice to say "V2 or > later" and copy it into the mx2fb.h? If I do that, add the imxdev.org > links into the commit message and tersely say there how I changed the > source (left out 24bpp and splash_is_in_mmc support), would that be good > enough?
Yes, I think so. The original header in mx2fb.h mentions GPLv2 or later. You should add similar header to mx2fb.c also, adding a header like /* * Copyright 2004-2009 Freescale Semiconductor, Inc. * * This file is released under the terms of GPL v2 and any later version. * See the file COPYING in the root directory of the source tree for details. */ should be enough. Thanks, Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
