On Wed, Jan 4, 2012 at 6:26 PM, Andreas Müller <schnitzelt...@gmx.de> wrote: > At old overo boards TWL4030 RTC irq is connected to gpio112. Unfortunately > this pin is also used for revision detection. Therefore we need to send > shut-up to TWL4030 to avoid reading wrong revision. In SPL this must > be done before SDRAM is set up because the type of SDRAM is revision > dependent. > By this patch it is ensured that all variables used by omap24xx_i2c.c are > located in SRAM. > > Signed-off-by: Andreas Müller <schnitzelt...@gmx.de> > --- > drivers/i2c/omap24xx_i2c.c | 13 +++++++++---- > 1 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c > index 271ed60..44290b4 100644 > --- a/drivers/i2c/omap24xx_i2c.c > +++ b/drivers/i2c/omap24xx_i2c.c > @@ -35,10 +35,15 @@ static void wait_for_bb(void); > static u16 wait_for_pin(void); > static void flush_fifo(void); > > -static struct i2c *i2c_base = (struct i2c *)I2C_DEFAULT_BASE; > - > -static unsigned int bus_initialized[I2C_BUS_MAX]; > -static unsigned int current_bus; > +/* > + * For SPL boot some boards need i2c before SDRAM is initialised so force > + * variables to live in SRAM > + */ > +static struct i2c __attribute__ ((section (".data"))) *i2c_base = > + (struct i2c *)I2C_DEFAULT_BASE;
__attribute__ ((...)) is a checkpatch warning, so I've changed this to __attribute__((..)) in my commit. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot