Hi Albert, On 08/10/2011 02:36 PM, Albert ARIBAUD wrote: > Hi Hong Xu, > > Le 10/08/2011 08:17, Hong Xu a écrit : > >> There are some ARM926 specific code in arch/arm/lib/cache.c; So I also >> put the stuff there. ;-) I think Albert Aribaud or the original >> contributor of cache part shall have clearer view.So, I'll keep neutral >> to hear more ideas. > > Basically, cache operations are CP15 commands which are defined for each > ARM architecture, not for each ISA, so Marek is right about the best > place for this being in arm926ejs. Actually, I think > arch/arm/lib/cache.c should only contain the weak defaults (i.e., no > real cache action) and each architecture should provide overrides to the > defaults. Currently this is almost the case, with (apart from arm926ejs > which you're already touching) only one arm1136 specific implementation > to move. > > So please move the arm926ejs specific implementations to > arch/arm/cpu/arm926ejs/cache.c as suggested by Marek, keeping only the > weak default in arch/arm/lib/cache.c.
Ok, I'll manage a basic version for review. Thanks BR, Eric > > Amicalement, _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
