Hi Marek Vasut, On 08/10/2011 01:52 PM, Marek Vasut wrote: > On Wednesday, August 10, 2011 04:49:25 AM Hong Xu wrote: >> After DMA operation, we need to maintain D-Cache coherency. >> So that the DCache must be invalidated (hence CPU will fetch >> data written by DMA controller from RAM). >> >> Tested on AT91SAM9261EK with Peripheral DMA controller. > > Hi Hong, > > one more thing, not that I want to disappoint you.
Not at all ;-) To raise such discussion is not bad actually. > Try to take a look at arch/arm/cpu/armv7/cache_v7.c > > Maybe we should do the same for arm926ejs -- have > arch/arm/cpu/arm926ejs/cache.c > -- containing arm926ejs specific cache management functions. That way, > arch/arm/lib/cache.c won't become mess. > > What do you think ? Basically I'm not quite sure about the design of ARM cache part. I noticed the work for armv7, but I've thought it as a special case because armv7 cache part looks more complicated than ARM926. There are some ARM926 specific code in arch/arm/lib/cache.c; So I also put the stuff there. ;-) I think Albert Aribaud or the original contributor of cache part shall have clearer view.So, I'll keep neutral to hear more ideas. BR, Eric >> >> Signed-off-by: Hong Xu<hong...@atmel.com> >> Tested-by: Elen Song<elen.s...@atmel.com> >> CC: Albert Aribaud<albert.u.b...@aribaud.net> >> CC: Aneesh V<ane...@ti.com> >> CC: Marek Vasut<marek.va...@gmail.com> >> CC: Reinhard Meyer<u-b...@emk-elektronik.de> >> CC: Heiko Schocher<h...@denx.de> >> --- >> V2: >> Per Albert's suggestion, add invalidate_dcache_range >> >> V3: >> invalidate_dcache_range emits warning when detecting unaligned buffer >> >> invalidate_dcache_range won't clean any adjacent cache line when >> detecting unaligned buffer and only round up/down the buffer address >> >> v4: >> invalidate_dcache_range will emit clearer warning message >> >> Per Albert's suggestion, if not alighed to cache line size, round up >> start address, round down stop addres >> >> Per Marek Vasut's suggestion, use __func__ stated in C99 >> >> arch/arm/lib/cache.c | 58 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 58 >> insertions(+), 0 deletions(-) >> [...] _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
