On 11/25/25 10:41 AM, Jerome Forissier wrote:
Hello Jerome,
linux (master)$ git log --oneline --no-merges v3.19-rc1..HEAD drivers/usb/dwc3
| wc -l
1347
That's a lot of commits. What exactly do we gain by doing this? Some
of the commits are not applicable to u-boot or need adaptations
(unsupported platforms, power management, debug/tracing, interrupts,
and probably other things I don't remember).
History of changes and likely git bisect ability.
It would be at least good to know, which of the kernel patches are part
of the U-Boot DWC3 stack and which are missing, otherwise we might be
missing fixes that are in Linux, which worries me.
- Check what might be missing
Essentially, many of the u-boot commits in:
u-boot (master)$ git log --oneline --no-merges 85d5e7075f3..HEAD
drivers/usb/dwc3 | wc -l
216
I compared the linux and u-boot commit log and only 13 of these 216
commits have the exact same subject as a Linux commit after v3.19-rc1.
So that's probably 13 cherry-picks and 203 commits that are more or
less u-boot specific.
That means U-Boot dwc3 driver started diverging, but also picked random
change from Linux here and there (see paragraph above).
Also note that the DWC3 driver has dependencies on:
drivers/usb/host/xhci-ext-caps.h
drivers/usb/gadget/epautoconf.c
drivers/usb/gadget/udc/udc-core.c
...which also need to be synced so that's a few more commits to
cherry-pick actually.
All things being considered, I think it is better to minimize the
number of commits. Sync with linux then fix. We can probably squash
the first three commits in my series so that only one commit is broken
build-wise. This way there is little impact on bisectability.
In any case we also need more testing on real boards.
I wonder if we could pick patches on top of the old U-Boot dwc3 import
commit, if we could at least understand that the additions won't break
existing DWC3 support. Because those picked patches could at least be
understood, unlike a mega-commit.
