Dear Wolfgang, On Wednesday 15 June 2011 03:48 PM, Wolfgang Denk wrote: > Dear Aneesh V, >
[snip ..] >> No. That wouldn't serve the purpose. I need two macros to distinguish >> between the two cases. >> 1. 'debug()' - can be used in all places at which console is guaranteed >> to be initialized whether executed as part of U-Boot or SPL. >> 2. 'spl_debug()' to be used at places where console is initialized for >> SPL but not for U-Boot (eg. lowlevel_init()) - so emit no code for >> U-Boot. > > You see - this distinction is becoming a mess. Let's get rid of this > and use common code for both cases. I replaced spl_debug() with debug() now. I moved sdram_init() out of lowlevel_init() for u-boot so that console is available by the time sdram_init() runs. However, clock init needs to remain in lowlevel_init() and I still feel that some debug traces from this module will be a good debugging tool for SPL, so I retained the traces and added something like this in arch/arm/cpu/armv7/omap4/clocks.c: /* * printing to console doesn't work unless * this code is executed from SPL */ #ifndef CONFIG_PRELOADER #define printf(fmt, args...) #define puts(s) #endif Is that fine? best regards, Aneesh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
