Hi Heiko, On 2025-04-14 22:01, Heiko Stuebner wrote: > From: Elaine Zhang <zhangq...@rock-chips.com> > > The current DT bindings for the rk3576 clock use a different ID than the > one that is supposed to be written to the hardware registers. > Thus, we cannot use directly the id provided in the phandle, but rather > use a lookup table to correctly setup the hardware. > > This follows the implementation done in the Linux-Kernel and also > how the rk3588 does this both in the Linux-Kernel as well as U-Boot. > > Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> > [adapted from mainline Linux code for u-boot] > Signed-off-by: Heiko Stuebner <he...@sntech.de> > --- > arch/arm/include/asm/arch-rockchip/clock.h | 10 + > drivers/reset/Makefile | 2 +- > drivers/reset/rst-rk3576.c | 647 +++++++++++++++++++++ > 3 files changed, 658 insertions(+), 1 deletion(-) > create mode 100644 drivers/reset/rst-rk3576.c
[snip] > diff --git a/drivers/reset/rst-rk3576.c b/drivers/reset/rst-rk3576.c > new file mode 100644 > index 00000000000..e64e27c1987 > --- /dev/null > +++ b/drivers/reset/rst-rk3576.c > @@ -0,0 +1,647 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (c) 2021 Rockchip Electronics Co., Ltd. > + * Copyright (c) 2024 Collabora Ltd. > + * Author: Detlev Casanova <detlev.casan...@collabora.com> > + * Based on Sebastien Reichel's implementation for RK3588 nitpick: s/Sebastien/Sebastian/ ? Regardless, this is: Reviewed-by: Jonas Karlman <jo...@kwiboo.se> Regards, Jonas > + */ > +