Hi Heiko,
On 2025-04-14 22:01, Heiko Stuebner wrote:
> The ROC-RK3576-PC is a SBC made by Firefly, designed around the RK3576
> SoC. This adds the needed board infrastructure and config for it.
>
> Signed-off-by: Heiko Stuebner <he...@sntech.de>
> ---
> arch/arm/dts/rk3576-roc-pc-u-boot.dtsi | 11 ++++++
> arch/arm/mach-rockchip/rk3576/Kconfig | 8 +++++
> board/firefly/roc-pc-rk3576/Kconfig | 12 +++++++
> board/firefly/roc-pc-rk3576/MAINTAINERS | 7 ++++
> configs/roc-pc-rk3576_defconfig | 45 +++++++++++++++++++++++++
> doc/board/rockchip/rockchip.rst | 3 ++
> include/configs/roc-pc-rk3576.h | 15 +++++++++
> 7 files changed, 101 insertions(+)
> create mode 100644 arch/arm/dts/rk3576-roc-pc-u-boot.dtsi
> create mode 100644 board/firefly/roc-pc-rk3576/Kconfig
> create mode 100644 board/firefly/roc-pc-rk3576/MAINTAINERS
> create mode 100644 configs/roc-pc-rk3576_defconfig
> create mode 100644 include/configs/roc-pc-rk3576.h
>
> diff --git a/arch/arm/dts/rk3576-roc-pc-u-boot.dtsi
> b/arch/arm/dts/rk3576-roc-pc-u-boot.dtsi
> new file mode 100644
> index 00000000000..97240345ed4
> --- /dev/null
> +++ b/arch/arm/dts/rk3576-roc-pc-u-boot.dtsi
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2023 Joshua Riek <jjr...@verizon.net>
> + *
> + */
> +
> +#include "rk3576-u-boot.dtsi"
> +
> +&sdhci {
> + cap-mmc-highspeed;
> +};
> diff --git a/arch/arm/mach-rockchip/rk3576/Kconfig
> b/arch/arm/mach-rockchip/rk3576/Kconfig
> index a94dc6706f0..83d41f7a100 100644
> --- a/arch/arm/mach-rockchip/rk3576/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3576/Kconfig
> @@ -1,5 +1,11 @@
> if ROCKCHIP_RK3576
>
> +config TARGET_ROC_PC_RK3576
> + bool "Firefly ROC-RK3576-PC"
> + help
> + ROC-RK3576-PC is a single board computer from Firefly
> + using the Rockchip RK3576.
> +
> config ROCKCHIP_BOOT_MODE_REG
> default 0x26024040
>
> @@ -12,4 +18,6 @@ config SYS_SOC
> config SYS_CONFIG_NAME
> default "rk3576_common"
>
> +source board/firefly/roc-pc-rk3576/Kconfig
This line should be added before the "config SYS_CONFIG_NAME" above,
else the default SYS_CONFIG_NAME defined in the board Kconfig does not
take effect and rk3576_common.h will be included instead of
roc-pc-rk3576.h.
With that fixed this is:
Reviewed-by: Jonas Karlman <jo...@kwiboo.se>
Regards,
Jonas
> +
> endif
> diff --git a/board/firefly/roc-pc-rk3576/Kconfig
> b/board/firefly/roc-pc-rk3576/Kconfig
> new file mode 100644
> index 00000000000..2fc0f913c37
> --- /dev/null
> +++ b/board/firefly/roc-pc-rk3576/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_ROC_PC_RK3576
> +
> +config SYS_BOARD
> + default "roc-pc-rk3576"
> +
> +config SYS_VENDOR
> + default "firefly"
> +
> +config SYS_CONFIG_NAME
> + default "roc-pc-rk3576"
> +
> +endif
[snip]
