Re: [PATCH 06/11] rockchip: Use rk3568_common.h by default for RK356x boards

[Kever Yang]

On 2025/4/6 08:24, Jonas Karlman wrote:

Ensure rk3568_common.h can be used by boards directly by defining a
blank ROCKCHIP_DEVICE_SETTINGS unless it already is defined.

Add a default SYS_CONFIG_NAME to include rk3568_common.h unless a board
target overrides it in its board Kconfig.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
  arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++
  include/configs/rk3568_common.h       | 4 ++++
  2 files changed, 7 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig 
b/arch/arm/mach-rockchip/rk3568/Kconfig
index a271782fac5c..8cad77890f13 100644
--- a/arch/arm/mach-rockchip/rk3568/Kconfig
+++ b/arch/arm/mach-rockchip/rk3568/Kconfig
@@ -81,4 +81,7 @@ source "board/qnap/ts433/Kconfig"
  source "board/radxa/zero3-rk3566/Kconfig"
  source "board/xunlong/orangepi-3b-rk3566/Kconfig"

+config SYS_CONFIG_NAME

+       default "rk3568_common"
+
  endif
diff --git a/include/configs/rk3568_common.h b/include/configs/rk3568_common.h
index a68ca381db57..b2a35db0b949 100644
--- a/include/configs/rk3568_common.h
+++ b/include/configs/rk3568_common.h
@@ -15,6 +15,10 @@
  #define CFG_SYS_SDRAM_BASE            0
  #define SDRAM_MAX_SIZE                        0xf0000000

+#ifndef ROCKCHIP_DEVICE_SETTINGS

+#define ROCKCHIP_DEVICE_SETTINGS
+#endif
+
  #define ENV_MEM_LAYOUT_SETTINGS               \
        "scriptaddr=0x00c00000\0"     \
        "script_offset_f=0xffe000\0"  \