Re: [PATCH 07/11] rockchip: Use rk3588_common.h by default for RK3588 boards

[Kever Yang]

On 2025/4/6 08:24, Jonas Karlman wrote:

Ensure rk3588_common.h can be used by boards directly by defining a
blank ROCKCHIP_DEVICE_SETTINGS unless it already is defined.

Add a default SYS_CONFIG_NAME to include rk3588_common.h unless a board
target overrides it in its board Kconfig.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
  arch/arm/mach-rockchip/rk3588/Kconfig | 3 +++
  include/configs/rk3588_common.h       | 4 ++++
  2 files changed, 7 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig 
b/arch/arm/mach-rockchip/rk3588/Kconfig
index 1c6a85d07394..8acb6618718f 100644
--- a/arch/arm/mach-rockchip/rk3588/Kconfig
+++ b/arch/arm/mach-rockchip/rk3588/Kconfig
@@ -441,4 +441,7 @@ source "board/rockchip/toybrick_rk3588/Kconfig"
  source "board/theobroma-systems/jaguar_rk3588/Kconfig"
  source "board/theobroma-systems/tiger_rk3588/Kconfig"

+config SYS_CONFIG_NAME

+       default "rk3588_common"
+
  endif
diff --git a/include/configs/rk3588_common.h b/include/configs/rk3588_common.h
index 7b02560971ad..2f0d40deb640 100644
--- a/include/configs/rk3588_common.h
+++ b/include/configs/rk3588_common.h
@@ -14,6 +14,10 @@
  #define CFG_SYS_SDRAM_BASE            0
  #define SDRAM_MAX_SIZE                        0xf0000000

+#ifndef ROCKCHIP_DEVICE_SETTINGS

+#define ROCKCHIP_DEVICE_SETTINGS
+#endif
+
  #define ENV_MEM_LAYOUT_SETTINGS               \
        "scriptaddr=0x00c00000\0"     \
        "script_offset_f=0xffe000\0"  \