On Thu, Dec 19, 2024 at 6:57 PM Alice Guo <alice....@oss.nxp.com> wrote: > > From: Ye Li <ye...@nxp.com> > > This patch adds i.MX95 19x19 EVK board basic support. > > Signed-off-by: Ye Li <ye...@nxp.com> > Signed-off-by: Alice Guo <alice....@nxp.com> > Reviewed-by: Peng Fan <peng....@nxp.com> > --- > arch/arm/dts/imx95-19x19-evk-u-boot.dtsi | 224 > ++++++++++++++++++++++++++ > arch/arm/mach-imx/imx9/Kconfig | 6 + > arch/arm/mach-imx/imx9/scmi/container.cfg | 10 ++ > arch/arm/mach-imx/imx9/scmi/imximage.cfg | 15 ++ > arch/arm/mach-imx/imx9/scmi/soc.c | 1 + > board/freescale/imx95_evk/Kconfig | 12 ++ > board/freescale/imx95_evk/MAINTAINERS | 6 + > board/freescale/imx95_evk/Makefile | 11 ++ > board/freescale/imx95_evk/imx95_19x19_evk.env | 95 +++++++++++ > board/freescale/imx95_evk/imx95_evk.c | 54 +++++++ > board/freescale/imx95_evk/spl.c | 117 ++++++++++++++ > configs/imx95_19x19_evk_defconfig | 178 ++++++++++++++++++++ > doc/board/nxp/imx95_evk.rst | 109 +++++++++++++ > doc/board/nxp/index.rst | 1 + > include/configs/imx95_evk.h | 36 +++++ > 15 files changed, 875 insertions(+) >
Hi Alice, I found some issues with imx95_19x19_evk.env (see below) <snip> > diff --git a/board/freescale/imx95_evk/imx95_19x19_evk.env > b/board/freescale/imx95_evk/imx95_19x19_evk.env > new file mode 100644 > index > 0000000000000000000000000000000000000000..27e09d3d70a068efb97d69b27089d1f213f39ee9 > --- /dev/null > +++ b/board/freescale/imx95_evk/imx95_19x19_evk.env > @@ -0,0 +1,95 @@ > +sec_boot=no > +initrd_addr=0x93800000 > +emmc_dev=0 > +sd_dev=1 > +prepare_mcore=setenv mcore_clk clk-imx95.mcore_booted I see where mcore_clk is used but nothing uses prepare_mcore. Also there is no upstream Linux clk-imx95 driver yet so this really doesn't do anything useful. Has a clk-imx95 driver been submitted? > +scriptaddr=0x93500000 > +kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) " for a .env file you can't use stringify. Just use the config without quotes: kernel_addr_r=CONFIG_SYS_LOAD_ADDR > +image=Image > +splashimage=0xA0000000 > +console=ttyLP0,115200 earlycon > +fdt_addr_r=0x93000000 > +fdt_addr=0x93000000 > +cntr_addr=0xA8000000 > +cntr_file=os_cntr_signed.bin > +boot_fit=no > +fdtfile=" CONFIG_DEFAULT_FDT_FILE " fdtfile=CONFIG_DEFAULT_FDT_FILE > +bootm_size=0x10000000 > +mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV)" mmcdev=CONFIG_SYS_MMC_ENV_DEV but you should probably just eliminate this one as its set at runtime in board_late_mmc_env_init() > +mmcpart=1 > +mmcroot=/dev/mmcblk1p2 rootwait rw This is also redundant as its set at runtime in board_late_mmc_env_init() Best Regards, Tim