Hi Luca, > Detlev Zundel wrote: >> >> I'll start a new thread to discuss this. Hopefully we then come up with >> a policy to stick into that wiki page. >> > > Now that the checkpatch policy is much more clear, I started to clean up > the networking stuff, on top of which the TFTP server sits.
Thanks a lot for starting this cleanup. Your work is very much appreciated. > net/net.c alone counts 76 errors and 197 warnings. In terms of modified > lines, it's going to be a big job, so I am doing it in separate patches, one > per each category of errors/warnings (whitespace issues, lines >80 chars, > parentheses issues etc). > Is this choice ok? This makes sense to me yes. > Also, it's going to be a bigger job than the TFTP server itself, so > I'll send a > separate patchset for the cleanup work, and hold the TFTP server until the > cleanup is worked out. If you really start the clenaup, then this order makes absolute sense. Thanks in advance! Detlev -- Every time history repeats itself the price goes up. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
