On Tue, Jun 04, 2024 at 07:57:38AM +0200, Heinrich Schuchardt wrote:
> On 6/4/24 05:34, Brunham, Kalen wrote:
> > Hi Tom/Heinrich,
> > 
> > I have https://github.com/u-boot/u-boot/pull/574 that has a proposed 
> > change. It is currently failing clang sandbox, which looks a little strange 
> > and I'm looking into it. Please let me know if you have any feedback on the 
> > general strategy.
> > 
> > Thanks,
> > -Kalen
> > 
> > -----Original Message-----
> > From: Tom Rini <tr...@konsulko.com>
> > Sent: Monday, June 3, 2024 1:23 PM
> > To: Brunham, Kalen <kalen.brun...@intel.com>
> > Cc: Jiaxun Yang <jiaxun.y...@flygoat.com>; Heinrich Schuchardt 
> > <xypron.g...@gmx.de>; Ilias Apalodimas <ilias.apalodi...@linaro.org>; 
> > U-Boot@lists.denx.de
> > Subject: Re: [PATCH 1/1] Added arm64 assembly for examples/api crt0
> > 
> > On Sun, Jun 02, 2024 at 12:16:38AM +0000, Brunham, Kalen wrote:
> > > Thanks Tom.
> > > 
> > > Can you suggest who is the existing owner of this code I could work with?
> > 
> > You should CC Heinrich for sure once you have things working.
> > 
> > > 
> > > -----Original Message-----
> > > From: Tom Rini <tr...@konsulko.com>
> > > Sent: Friday, May 31, 2024 12:03 PM
> > > To: Brunham, Kalen <kalen.brun...@intel.com>
> > > Cc: Jiaxun Yang <jiaxun.y...@flygoat.com>; Heinrich Schuchardt 
> > > <xypron.g...@gmx.de>; Ilias Apalodimas <ilias.apalodi...@linaro.org>; 
> > > U-Boot@lists.denx.de
> > > Subject: Re: [PATCH 1/1] Added arm64 assembly for examples/api crt0
> > > 
> > > On Thu, May 30, 2024 at 02:53:17PM +0000, Brunham, Kalen wrote:
> > > 
> > > > Hi Tom,
> > > > 
> > > > What are next steps on this change?
> > > > 
> > > > I'm committed to the idea of EFI apps opposed to examples/standalone.
> > > > EFI currently requires block devices which is not enabled when only 
> > > > using flash.
> > > > 
> > > > Should config BLK be updated to include DM_SPI_FLASH?
> 
> The UEFI implementation should not depend on DM_SPI_FLASH.
> 
> You could make BLK manually selectable again instead:
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 6ad18889f61..1f0e1010f0e 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -1,5 +1,5 @@
>  config BLK
> -       bool # "Support block devices"
> +       bool "Support block devices"
> 
> Cf. 0417b8523c47 ("blk: Hide the BLK and SPL_LEGACY_BLOCK options")

They're hidden on purpose because most things should select them, not
depend on them. If EFI_LOADER is making its own virtual block devices,
it should be select'ing it not depending on it. There's a few other
places getting this backwards I see.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to