Hi Neha,
On 18:39-20230927, Neha Malcom Francis wrote:
> When setting boot media to load the TIFS binary in legacy boot flow
> (followed by J721E), get_timer() is called which eventually calls
> dm_timer_init() to grab the tick-timer, which is mcu_timer0. Since we
> need to set up the clocks before using the timer, move clk_k3 driver
> probe before k3_sysfw_loader to ensure we have all necessary clocks set
> up before.
>
> Signed-off-by: Neha Malcom Francis <n-fran...@ti.com>
> Reviewed-by: Nishanth Menon <n...@ti.com>
> ---
> arch/arm/mach-k3/j721e_init.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> index b6164575b7..b1f7e25ed0 100644
> --- a/arch/arm/mach-k3/j721e_init.c
> +++ b/arch/arm/mach-k3/j721e_init.c
> @@ -228,6 +228,18 @@ void board_init_f(ulong dummy)
> if (!ret)
> pinctrl_select_state(dev, "default");
>
> + /*
> + * Force probe of clk_k3 driver here to ensure basic default clock
> + * configuration is always done.
> + */
> + if (IS_ENABLED(CONFIG_SPL_CLK_K3)) {
> + ret = uclass_get_device_by_driver(UCLASS_CLK,
> + DM_DRIVER_GET(ti_clk),
> + &dev);
> + if (ret)
> + panic("Failed to initialize clk-k3!\n");
> + }
> +
> /*
> * Load, start up, and configure system controller firmware. Provide
> * the U-Boot console init function to the SYSFW post-PM configuration
> @@ -241,18 +253,6 @@ void board_init_f(ulong dummy)
> do_dt_magic();
> #endif
>
> - /*
> - * Force probe of clk_k3 driver here to ensure basic default clock
> - * configuration is always done.
> - */
> - if (IS_ENABLED(CONFIG_SPL_CLK_K3)) {
> - ret = uclass_get_device_by_driver(UCLASS_CLK,
> - DM_DRIVER_GET(ti_clk),
> - &dev);
> - if (ret)
> - panic("Failed to initialize clk-k3!\n");
> - }
> -
> /* Prepare console output */
> preloader_console_init();
>
Reviewed-by: Manorit Chawdhry <m-chawd...@ti.com>
Regards,
Manorit
> diff --git a/arch/arm/mach-k3/j721e_init.c b/arch/arm/mach-k3/j721e_init.c
> --
> 2.34.1
>
