On Thu, Apr 27, 2023 at 12:49 PM Fabio Estevam <feste...@gmail.com> wrote: > > On Thu, Apr 27, 2023 at 4:44 PM Tim Harvey <thar...@gateworks.com> wrote: > > > Fabio, > > > > Sorry for the confusion. > > > > This imx8mm dt sync patch will hang on imx8mm boards that use 'both' > > usbotg1 and usbotg2. You can reproduce this hang on your imx8mm-evk by > > enabling usbotg2 in the dt (the board has it but it is not enabled due > > to the gpio based usb 3.0 mux not being sorted out yet): > > +&usbotg2 { > > + dr_mode = "otg"; > > + status = "okay"; > > +}; > > + > > > > u-boot=> usb start && usb tree > > starting USB... > > Bus usb@32e40000: Bus usb@32e50000: > > ^^^ imx8mm-evk hangs > > Yes, I can reproduce the hang, but it happens with or without the > imx8mm dt sync. >
Fabio, I do 'not' see a hang on imx8mm-evk on 'usb start && usb tree' on master (my other issue was on a 'usb stop' but only with usb controllers in host mode). > This hang is a separate issue, not dt related, as far as I understand. > > The imx8mm dts sync does solve the issue of running 'ums' after CTRL+C. I don't agree. The hang 'is' related because all my imx8mm-venice-* boards which use 'both' USB controllers hang with this patch on a 'usb start' and don't hang without it. While a basic 'review' of the patch looks good but actual product testing shows issues. As a maintainer for ARM FREESCALE IMX you must have another imx8mm board which uses both usbotg devices to test against and verify you see what I see? Until we know what other fix is needed to go along with this: Nacked-by: Tim Harvey <thar...@gateworks.com> I've verified that it's the changes from Linux commit 4585c79ff477f ("arm64: dts: imx8mm: correct usb power domains") that causes the hang, but I don't know why yet. Why are we seeing different behavior on the imx8mm-evk? Are we on different branches? My testing today is on caf0a88d9f31 Best Regards, Tim