On Fri, Jan 13, 2023 at 01:59:20PM +0530, Nikhil M Jain wrote: > This patch updates the necessary Kconfigs to make simple panel > driver independent of backlight driver and compiling backlight > related code in simple-panel driver conditionally to when user > has set CONFIG_BACKLIGHT. > > Signed-off-by: Nikhil M Jain <n-ja...@ti.com> > --- > drivers/video/Kconfig | 3 +-- > drivers/video/simple_panel.c | 20 +++++++++++++------- > 2 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index c841b99bb3..5030586d9f 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -28,7 +28,6 @@ config VIDEO_LOGO > > config BACKLIGHT > bool "Enable panel backlight uclass support" > - default y > help > This provides backlight uclass driver that enables basic panel > backlight support.
Have you made sure this didn't disable / remove code on other platforms?
[snip]
> @@ -97,8 +101,10 @@ static int simple_panel_probe(struct udevice *dev)
> }
>
> static const struct panel_ops simple_panel_ops = {
> - .enable_backlight = simple_panel_enable_backlight,
> - .set_backlight = simple_panel_set_backlight,
> +#ifdef CONFIG_BACKLIGHT
> + .enable_backlight = simple_panel_enable_backlight,
> + .set_backlight = simple_panel_set_backlight,
> +#endif
> };
This shouldn't get indented more.
--
Tom
signature.asc
Description: PGP signature
