On Fri, Jan 13, 2023 at 01:59:19PM +0530, Nikhil M Jain wrote: > Added tidss video driver support which enables display > on oldi panel using AM62x, it creates a simple pipeline > framebuffer==>vidl1==>ovr1==>vp1==>oldi_panel and > sets clock rates for panel, pixel format and the media > bus format for panel. > > TIDSS is ported from linux kernel version 5.10.145. > > Signed-off-by: Nikhil M Jain <n-ja...@ti.com>
I don't have any big comments, just a few small things.
[snip]
> diff --git a/board/ti/am62x/MAINTAINERS b/board/ti/am62x/MAINTAINERS
> index 105e741995..7e6cc0b55e 100644
> --- a/board/ti/am62x/MAINTAINERS
> +++ b/board/ti/am62x/MAINTAINERS
> @@ -6,3 +6,4 @@ F: board/ti/am62x/
> F: include/configs/am62x_evm.h
> F: configs/am62x_evm_r5_defconfig
> F: configs/am62x_evm_a53_defconfig
> +F:
Not needed.
> diff --git a/drivers/video/tidss/Kconfig b/drivers/video/tidss/Kconfig
> new file mode 100644
> index 0000000000..9d137f83d8
> --- /dev/null
> +++ b/drivers/video/tidss/Kconfig
> @@ -0,0 +1,7 @@
> +menuconfig VIDEO_TIDSS
> + bool "Enable TIDSS video support"
> + depends on VIDEO
> + help
> + TIDSS supports video output options LVDS and
> + DPI . This option enables these supports which can be used on
> + devices which have OLDI or HDMI display connected.
> \ No newline at end of file
> diff --git a/drivers/video/tidss/Makefile b/drivers/video/tidss/Makefile
> new file mode 100644
> index 0000000000..fd323f2949
> --- /dev/null
> +++ b/drivers/video/tidss/Makefile
> @@ -0,0 +1 @@
> +obj-${CONFIG_VIDEO_TIDSS} = tidss_drv.o
> \ No newline at end of file
And there should be newlines at the end of files.
--
Tom
signature.asc
Description: PGP signature
