On Sunday, November 28, 2010 16:02:49 Wolfgang Denk wrote: > Mike Frysinger wrote: > > Use the new helper func to clean up duplicate logic handling of the > > autostart env var. > > > > Signed-off-by: Mike Frysinger <vap...@gentoo.org> > > --- > > > > common/cmd_fdc.c | 3 +-- > > common/cmd_fdos.c | 2 +- > > common/cmd_ide.c | 2 +- > > common/cmd_nand.c | 4 ++-- > > common/cmd_net.c | 2 +- > > common/cmd_scsi.c | 2 +- > > common/cmd_usb.c | 2 +- > > 7 files changed, 8 insertions(+), 9 deletions(-) > > Applied to "next" branch, thanks.
hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it boils down to default values when the env var is not set. some places interpret this to mean "yes" while others expect "no". getenv_yesno() takes the "no" default which doesnt always work. i can update the API to take a 2nd arg (the default value), or we can punt this patch. it's in "next", so there's less pressure to get it fixed immediately ... -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
