> Mike Rapoport wrote, on 11/23/2010 01:29 AM: > minor comments follow: > [...] > > diff --git a/board/cm_t35/cm_t35.h b/board/cm_t35/cm_t35.h > > new file mode 100644 > > index 0000000..514017d > > --- /dev/null > > +++ b/board/cm_t35/cm_t35.h > [..] > /*DSS_DATA22*/\ > > + MUX_VAL(CP(DSS_DATA23), (IDIS | PTD | DIS | M0)) > /*DSS_DATA23*/\ > Are you using bootlogo in CM-t35 u-boot? > > > > + MUX_VAL(CP(SYS_CLKOUT1), (IEN | PTD | DIS | M0)) /*CLKOUT1*/\ > > + MUX_VAL(CP(SYS_CLKOUT2), (IDIS | PTD | DIS | M4)) /*green > LED*/\ > might be better to state which GPIO than green led :) > > > + MUX_VAL(CP(JTAG_nTRST), (IEN | PTD | DIS | M0)) > /*JTAG_nTRST*/\ > > + MUX_VAL(CP(JTAG_TCK), (IEN | PTD | DIS | M0)) /*JTAG_TCK*/\ > > + MUX_VAL(CP(JTAG_TMS), (IEN | PTD | DIS | M0)) /*JTAG_TMS*/\ > > + MUX_VAL(CP(JTAG_TDI), (IEN | PTD | DIS | M0)) /*JTAG_TDI*/\ > > > + MUX_VAL(CP(SDRC_CKE0), (IDIS | PTU | EN | M0)) > /*sdrc_cke0*/\ > > + MUX_VAL(CP(SDRC_CKE1), (IDIS | PTD | DIS | M7)) > /*sdrc_cke1*/\ > this tiny set probably should go along with sdrc to reflect proper > functional set I guess. >
Mike can you respond to these comments from Nishanth? I'd really like to add this 1 year old patch u-boot. --Sandeep _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
