Hi Alex, Thanks for reporting! With rockchip,dw-hdmi.yaml all kind notifications rk3328/rk3399 but not for ddc-i2c-scl-* Submitted by Laurent, but not reviewed/fixed nodes together with the Rockchip mail group. Someone has to look at/fix it...
dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210114064437.5793-6-laurent.pinchart+rene...@ideasonboard.com/ Will change that for A95X-Z2. Waiting for some more comments... ;) Johan On 7/1/21 1:46 PM, Alex Bee wrote: > Hi Johan, > > Am 30.06.21 um 18:22 schrieb Johan Jonker: >> With a new board from a recent Linux DT the U-boot rk3328.dtsi >> is in need for an update. >> >> Please advise what to do with usb3 regulators, aliases and >> other stuff that has to change. >> >> Also some of the U-boot board files could use some >> dtbs_check for bogus properties and restyling... ;) > > While at bogus properties: > The ddc-i2c-scl-* properties you are defining in the hdmi node of > rk3318-a95x-z2.dts look like an leftover from vendor kernel: they do not > exist for the upstream dw-hdmi driver in neither u-boot nor kernel. > (Not sure this would pop up with dtbs_check currently) make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml /arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml: hdmi@ff3c0000: interrupts: [[0, 35, 4], [0, 71, 4]] is too long From schema: /Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml /arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml: hdmi@ff3c0000: pinctrl-names: ['default'] is too short From schema: /Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml /arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml: hdmi@ff3c0000: ports:port: 'endpoint@0' is a required property From schema: /Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml /arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml: hdmi@ff3c0000: ports:port: 'endpoint@1' is a required property From schema: /Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > Alex. >> >> rk3328 USB2 and USB3 only roughly tested. >> >> === >> >> Howto use: >> >> Compile bl31.elf: >> >> git clone --depth 1 >> https://github.com/ARM-software/arm-trusted-firmware.git >> cd arm-trusted-firmware >> make realclean >> make CROSS_COMPILE=aarch64-linux-gnu- PLAT=rk3328 >> >> export >> BL31=/<path-to>/arm-trusted-firmware/build/rk3328/release/bl31/bl31.elf >> cd .. >> >> Compile U-boot: >> >> git clone --depth 1 https://github.com/u-boot/u-boot.git uboot >> cd uboot >> make CROSS_COMPILE=aarch64-linux-gnu- a95x-z2-rk3318_defconfig all >> >> === >> >> Use U-boot to create a GPT on a SD card, >> because of partition GUID and sizes. >> >> mmc dev 0 >> mmc info >> gpt write mmc 0 $partitions >> mmc part >> >> === >> >> Write to SD card: >> >> export DISK=/dev/mmcblk0 >> sudo dd if=./idbloader.img of=${DISK} seek=64 >> sudo dd if=./u-boot.itb of=${DISK} seek=16384 >> sync >> >> === >> >> Format boot partition with fat16. >> Add /Image and /rk3318-a95x-z2.dtb >> Add extlinux dir with extlinux.conf >> >> label kernel >> kernel /Image >> fdt /rk3318-a95x-z2.dtb >> append root=/dev/mmcblk0p5 rw console=tty0 >> console=ttyS2,1500000n8 earlycon=uart8250,mmio32,0xff130000,keep $ >> >> === >> >> Use fastboot: >> >> Hit any key to stop autoboot: >> usb start >> usb dev 1 >> fastboot usb 1 >> = >> sudo fastboot devices -l >> sudo fastboot erase loader1 >> sudo fastboot erase loader2 >> sudo fastboot flash loader1 idbloader.img >> sudo fastboot flash loader2 u-boot.itb >> = >> ctrl-c >> reset >> >> === >> >> Johan Jonker (6): >> arm: dts: rockchip: update rk3328.dtsi >> arm: dts: rockchip: remove usb_host0_xhci node from rk3328-u-boot.dtsi >> arm: dts: rockchip: move mmc aliases to board files >> arm: dts: rockchip: move spi0 u-boot,dm-pre-reloc and alias to rk3328 >> board files >> rockchip: rk3318: add a95x-z2-rk3318_defconfig file >> arm: dts: rockchip: add rk3318 A95X Z2 board >> >> arch/arm/dts/Makefile | 1 + >> arch/arm/dts/rk3318-a95x-z2-u-boot.dtsi | 59 +++++ >> arch/arm/dts/rk3318-a95x-z2.dts | 384 >> +++++++++++++++++++++++++++++ >> arch/arm/dts/rk3328-evb-u-boot.dtsi | 2 +- >> arch/arm/dts/rk3328-evb.dts | 8 +- >> arch/arm/dts/rk3328-nanopi-r2s-u-boot.dtsi | 2 +- >> arch/arm/dts/rk3328-nanopi-r2s.dts | 6 +- >> arch/arm/dts/rk3328-roc-cc-u-boot.dtsi | 4 +- >> arch/arm/dts/rk3328-roc-cc.dts | 7 +- >> arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi | 4 +- >> arch/arm/dts/rk3328-rock-pi-e.dts | 7 +- >> arch/arm/dts/rk3328-rock64-u-boot.dtsi | 10 +- >> arch/arm/dts/rk3328-rock64.dts | 7 +- >> arch/arm/dts/rk3328-u-boot.dtsi | 21 -- >> arch/arm/dts/rk3328.dtsi | 109 ++++---- >> board/rockchip/evb_rk3328/MAINTAINERS | 6 + >> configs/a95x-z2-rk3318_defconfig | 102 ++++++++ >> doc/board/rockchip/rockchip.rst | 2 + >> 18 files changed, 661 insertions(+), 80 deletions(-) >> create mode 100644 arch/arm/dts/rk3318-a95x-z2-u-boot.dtsi >> create mode 100644 arch/arm/dts/rk3318-a95x-z2.dts >> create mode 100644 configs/a95x-z2-rk3318_defconfig >> >
