Hi Marek,
Thank you for the patch.
On Wed, Apr 28, 2021 at 8:32 PM Marek Vasut <marek.va...@gmail.com> wrote:
>
> The MODEMR register offset changed on R8A779A0, make the MODEMR offset
> configurable. Fill the offset in on all clock drivers. No functional
> change.
>
> Based off "clk: renesas: Make CPG Reset MODEMR offset accessible from
> struct cpg_mssr_info" by Hai Pham <hai.pham...@renesas.com>
>
> Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com>
> ---
> drivers/clk/renesas/clk-rcar-gen2.c | 2 --
> drivers/clk/renesas/clk-rcar-gen3.c | 4 +---
> drivers/clk/renesas/r8a774a1-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a774b1-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a774c0-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a774e1-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7790-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7791-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7792-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7794-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a77965-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a77970-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a77980-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a77990-cpg-mssr.c | 1 +
> drivers/clk/renesas/r8a77995-cpg-mssr.c | 1 +
> drivers/clk/renesas/rcar-gen2-cpg.h | 2 ++
> drivers/clk/renesas/rcar-gen3-cpg.h | 2 ++
> drivers/clk/renesas/renesas-cpg-mssr.h | 1 +
> 20 files changed, 21 insertions(+), 5 deletions(-)
>
For RZ/G2{EHMN}
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad...@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/drivers/clk/renesas/clk-rcar-gen2.c
> b/drivers/clk/renesas/clk-rcar-gen2.c
> index b423c9414b..b0164a6486 100644
> --- a/drivers/clk/renesas/clk-rcar-gen2.c
> +++ b/drivers/clk/renesas/clk-rcar-gen2.c
> @@ -23,8 +23,6 @@
> #include "renesas-cpg-mssr.h"
> #include "rcar-gen2-cpg.h"
>
> -#define CPG_RST_MODEMR 0x0060
> -
> #define CPG_PLL0CR 0x00d8
> #define CPG_SDCKCR 0x0074
>
> diff --git a/drivers/clk/renesas/clk-rcar-gen3.c
> b/drivers/clk/renesas/clk-rcar-gen3.c
> index 763e268937..938d98546b 100644
> --- a/drivers/clk/renesas/clk-rcar-gen3.c
> +++ b/drivers/clk/renesas/clk-rcar-gen3.c
> @@ -25,8 +25,6 @@
> #include "renesas-cpg-mssr.h"
> #include "rcar-gen3-cpg.h"
>
> -#define CPG_RST_MODEMR 0x0060
> -
> #define CPG_PLL0CR 0x00d8
> #define CPG_PLL2CR 0x002c
> #define CPG_PLL4CR 0x01f4
> @@ -382,7 +380,7 @@ int gen3_clk_probe(struct udevice *dev)
> if (rst_base == FDT_ADDR_T_NONE)
> return -EINVAL;
>
> - cpg_mode = readl(rst_base + CPG_RST_MODEMR);
> + cpg_mode = readl(rst_base + info->reset_modemr_offset);
>
> priv->cpg_pll_config =
> (struct rcar_gen3_cpg_pll_config
> *)info->get_pll_config(cpg_mode);
> diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> index ef2bb6d777..48da65cd3d 100644
> --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> @@ -321,6 +321,7 @@ static const struct cpg_mssr_info r8a774a1_cpg_mssr_info
> = {
> .mstp_table = r8a774a1_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a774a1_mstp_table),
> .reset_node = "renesas,r8a774a1-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a774b1-cpg-mssr.c
> b/drivers/clk/renesas/r8a774b1-cpg-mssr.c
> index a8b242dc47..418c393a20 100644
> --- a/drivers/clk/renesas/r8a774b1-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774b1-cpg-mssr.c
> @@ -318,6 +318,7 @@ static const struct cpg_mssr_info r8a774b1_cpg_mssr_info
> = {
> .mstp_table = r8a774b1_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a774b1_mstp_table),
> .reset_node = "renesas,r8a774b1-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> index 6e9558a107..c1283d2614 100644
> --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> @@ -292,6 +292,7 @@ const struct cpg_mssr_info r8a774c0_cpg_mssr_info = {
> .mstp_table = r8a774c0_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a774c0_mstp_table),
> .reset_node = "renesas,r8a774c0-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> .clk_extalr_id = ~0,
> diff --git a/drivers/clk/renesas/r8a774e1-cpg-mssr.c
> b/drivers/clk/renesas/r8a774e1-cpg-mssr.c
> index c969ec6888..0cacd8d0c8 100644
> --- a/drivers/clk/renesas/r8a774e1-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774e1-cpg-mssr.c
> @@ -332,6 +332,7 @@ static const struct cpg_mssr_info r8a774e1_cpg_mssr_info
> = {
> .mstp_table = r8a774e1_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a774e1_mstp_table),
> .reset_node = "renesas,r8a774e1-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a7790-cpg-mssr.c
> b/drivers/clk/renesas/r8a7790-cpg-mssr.c
> index 8d616476c7..1f3477fa6e 100644
> --- a/drivers/clk/renesas/r8a7790-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7790-cpg-mssr.c
> @@ -263,6 +263,7 @@ static const struct cpg_mssr_info r8a7790_cpg_mssr_info =
> {
> .mstp_table = r8a7790_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7790_mstp_table),
> .reset_node = "renesas,r8a7790-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extal_usb_node = "usb_extal",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a7791-cpg-mssr.c
> b/drivers/clk/renesas/r8a7791-cpg-mssr.c
> index 7a89613b32..fcca7be886 100644
> --- a/drivers/clk/renesas/r8a7791-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7791-cpg-mssr.c
> @@ -265,6 +265,7 @@ static const struct cpg_mssr_info r8a7791_cpg_mssr_info =
> {
> .mstp_table = r8a7791_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7791_mstp_table),
> .reset_node = "renesas,r8a7791-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extal_usb_node = "usb_extal",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a7792-cpg-mssr.c
> b/drivers/clk/renesas/r8a7792-cpg-mssr.c
> index e18774dae4..5b333638ac 100644
> --- a/drivers/clk/renesas/r8a7792-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7792-cpg-mssr.c
> @@ -213,6 +213,7 @@ static const struct cpg_mssr_info r8a7792_cpg_mssr_info =
> {
> .mstp_table = r8a7792_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7792_mstp_table),
> .reset_node = "renesas,r8a7792-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> .pll0_div = 2,
> diff --git a/drivers/clk/renesas/r8a7794-cpg-mssr.c
> b/drivers/clk/renesas/r8a7794-cpg-mssr.c
> index 790bc1bbd9..b9dd88de98 100644
> --- a/drivers/clk/renesas/r8a7794-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7794-cpg-mssr.c
> @@ -240,6 +240,7 @@ static const struct cpg_mssr_info r8a7794_cpg_mssr_info =
> {
> .mstp_table = r8a7794_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7794_mstp_table),
> .reset_node = "renesas,r8a7794-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extal_usb_node = "usb_extal",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> index ca74250276..6ba796b98c 100644
> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -362,6 +362,7 @@ static const struct cpg_mssr_info r8a7795_cpg_mssr_info =
> {
> .mstp_table = r8a7795_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7795_mstp_table),
> .reset_node = "renesas,r8a7795-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> index 2e9a8b6448..e318719033 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -346,6 +346,7 @@ static const struct cpg_mssr_info r8a7796_cpg_mssr_info =
> {
> .mstp_table = r8a7796_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a7796_mstp_table),
> .reset_node = "renesas,r8a7796-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a77965-cpg-mssr.c
> b/drivers/clk/renesas/r8a77965-cpg-mssr.c
> index a839ffa41f..0a15617da8 100644
> --- a/drivers/clk/renesas/r8a77965-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c
> @@ -344,6 +344,7 @@ static const struct cpg_mssr_info r8a77965_cpg_mssr_info
> = {
> .mstp_table = r8a77965_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a77965_mstp_table),
> .reset_node = "renesas,r8a77965-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a77970-cpg-mssr.c
> b/drivers/clk/renesas/r8a77970-cpg-mssr.c
> index 3b84c658f7..a85bed6192 100644
> --- a/drivers/clk/renesas/r8a77970-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77970-cpg-mssr.c
> @@ -211,6 +211,7 @@ static const struct cpg_mssr_info r8a77970_cpg_mssr_info
> = {
> .mstp_table = r8a77970_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a77970_mstp_table),
> .reset_node = "renesas,r8a77970-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a77980-cpg-mssr.c
> b/drivers/clk/renesas/r8a77980-cpg-mssr.c
> index cf96309d12..bd9d7c9be5 100644
> --- a/drivers/clk/renesas/r8a77980-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77980-cpg-mssr.c
> @@ -230,6 +230,7 @@ static const struct cpg_mssr_info r8a77980_cpg_mssr_info
> = {
> .mstp_table = r8a77980_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a77980_mstp_table),
> .reset_node = "renesas,r8a77980-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .extalr_node = "extalr",
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> diff --git a/drivers/clk/renesas/r8a77990-cpg-mssr.c
> b/drivers/clk/renesas/r8a77990-cpg-mssr.c
> index d953c0b421..67a1f586e2 100644
> --- a/drivers/clk/renesas/r8a77990-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77990-cpg-mssr.c
> @@ -304,6 +304,7 @@ static const struct cpg_mssr_info r8a77990_cpg_mssr_info
> = {
> .mstp_table = r8a77990_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a77990_mstp_table),
> .reset_node = "renesas,r8a77990-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> .clk_extalr_id = ~0,
> diff --git a/drivers/clk/renesas/r8a77995-cpg-mssr.c
> b/drivers/clk/renesas/r8a77995-cpg-mssr.c
> index 0771c48964..83e8e9bfaa 100644
> --- a/drivers/clk/renesas/r8a77995-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77995-cpg-mssr.c
> @@ -242,6 +242,7 @@ static const struct cpg_mssr_info r8a77995_cpg_mssr_info
> = {
> .mstp_table = r8a77995_mstp_table,
> .mstp_table_size = ARRAY_SIZE(r8a77995_mstp_table),
> .reset_node = "renesas,r8a77995-rst",
> + .reset_modemr_offset = CPG_RST_MODEMR,
> .mod_clk_base = MOD_CLK_BASE,
> .clk_extal_id = CLK_EXTAL,
> .clk_extalr_id = ~0,
> diff --git a/drivers/clk/renesas/rcar-gen2-cpg.h
> b/drivers/clk/renesas/rcar-gen2-cpg.h
> index 2739480dad..ca7c3ed6b5 100644
> --- a/drivers/clk/renesas/rcar-gen2-cpg.h
> +++ b/drivers/clk/renesas/rcar-gen2-cpg.h
> @@ -30,6 +30,8 @@ struct rcar_gen2_cpg_pll_config {
> unsigned int pll0_mult; /* leave as zero if PLL0CR exists */
> };
>
> +#define CPG_RST_MODEMR 0x060
> +
> struct gen2_clk_priv {
> void __iomem *base;
> struct cpg_mssr_info *info;
> diff --git a/drivers/clk/renesas/rcar-gen3-cpg.h
> b/drivers/clk/renesas/rcar-gen3-cpg.h
> index 52526a0cab..4fce0a9946 100644
> --- a/drivers/clk/renesas/rcar-gen3-cpg.h
> +++ b/drivers/clk/renesas/rcar-gen3-cpg.h
> @@ -71,6 +71,8 @@ struct rcar_gen3_cpg_pll_config {
> u8 osc_prediv;
> };
>
> +#define CPG_RST_MODEMR 0x060
> +
> #define CPG_RPCCKCR 0x238
> #define CPG_RCKCR 0x240
>
> diff --git a/drivers/clk/renesas/renesas-cpg-mssr.h
> b/drivers/clk/renesas/renesas-cpg-mssr.h
> index b669dec594..ad5d269fc4 100644
> --- a/drivers/clk/renesas/renesas-cpg-mssr.h
> +++ b/drivers/clk/renesas/renesas-cpg-mssr.h
> @@ -22,6 +22,7 @@ struct cpg_mssr_info {
> const struct mstp_stop_table *mstp_table;
> unsigned int mstp_table_size;
> const char *reset_node;
> + unsigned int reset_modemr_offset;
> const char *extalr_node;
> const char *extal_usb_node;
> unsigned int mod_clk_base;
> --
> 2.30.2
>
