From: Ye Li <ye...@nxp.com>

When doing DDR scrub, the DDR may enter into self refresh if the
selfref_en is enabled before DDR scrub. This will cause scrub
can't complete that SBRSTAT.scrub_done won't be set.

Since the selfref_en can be programmed during the course of
normal operation, move it after DDR scrub

Signed-off-by: Ye Li <ye...@nxp.com>
Acked-by: Peng Fan <peng....@nxp.com>
Signed-off-by: Peng Fan <peng....@nxp.com>
---
 drivers/ddr/imx/imx8m/ddr_init.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/ddr/imx/imx8m/ddr_init.c b/drivers/ddr/imx/imx8m/ddr_init.c
index 65739dbaa7..57331649ac 100644
--- a/drivers/ddr/imx/imx8m/ddr_init.c
+++ b/drivers/ddr/imx/imx8m/ddr_init.c
@@ -236,8 +236,6 @@ int ddr_init(struct dram_timing_info *dram_timing)
 
        /* Step26: Set back register in Step4 to the original values if desired 
*/
        reg32_write(DDRC_RFSHCTL3(0), 0x0000000);
-       /* enable selfref_en by default */
-       setbits_le32(DDRC_PWRCTL(0), 0x1);
 
        /* enable port 0 */
        reg32_write(DDRC_PCTRL_0(0), 0x00000001);
@@ -245,6 +243,9 @@ int ddr_init(struct dram_timing_info *dram_timing)
 
        board_dram_ecc_scrub();
 
+       /* enable selfref_en by default */
+       setbits_le32(DDRC_PWRCTL(0), 0x1);
+
        /* save the dram timing config into memory */
        dram_config_save(dram_timing, CONFIG_SAVED_DRAM_TIMING_BASE);
 
-- 
2.28.0

Reply via email to