On Wed, Sep 16, 2020 at 05:53:35PM +0200, Martin Cerveny wrote: > On Wed, 16 Sep 2020, Maxime Ripard wrote: > > On Wed, Sep 16, 2020 at 04:10:51PM +0200, Martin Cerveny wrote: > > > Add support for DE2 and TCON connected LCD display. > > > Add support for export as "allwinner,simple-framebuffer" > > > with "mixer0-lcd0" pipeline. > > > > > > Signed-off-by: Martin Cerveny <m.cerv...@computer.org> > > > > You shouldn't do multiple things at once. If you need to, then split it > > into several patches. > > > > Maxime > > How to split - is three sufficient ? > - pwm pins & registration > - LCD pins & DE/TCOM registration > - choosen framebuffer-lcd
Yep, that sounds reasonable. For the last one though, we generally favor just sync'ing the Linux device tree Maxime
