On 05.08.20 19:13, Heinrich Schuchardt wrote: > On 28.07.20 20:57, Simon Glass wrote: >> On x86 various files that need to be created by binman. It does not make >> sense to enumerate these in the Makefile. They are described in the >> configuration (devicetree) for each board and we can simply run binman >> (always) to generate them. >> >> Update the Makefile to have a separate, final step which runs binman, >> once all input dependencies are present. >> >> This avoid sprinkling the Makefile with arch-specific code. >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> >> (no changes since v3) >> >> Changes in v3: >> - Drop rockchip changes which should not be in this patch >> >> Makefile | 63 +++++++++++++------------------------------------------- >> 1 file changed, 14 insertions(+), 49 deletions(-) >> >> Applied to u-boot-dm, thanks! >> > > Dear Simon, > > since this patch merged as 42b18df80fdb network is broken on the > pine64-lts_defconfig: > > Net: phy interface7 > Could not get PHY for ethernet@1c30000: addr 1 > No ethernet found. > > => dhcp > phy interface7 > mdio_register: non unique device name 'ethernet@1c30000' > Could not get PHY for ethernet@1c30000: addr 1 > > Please, provide a fix.
The last build steps with your patch are: cat spl/sunxi-spl.bin u-boot.itb > u-boot-sunxi-with-spl.bin ./tools/binman/binman --toolpath ./tools build -u -d u-boot.dtb -O . -m --allow-missing -I . -I . -I ./board/sunxi The file before binman is ok. After binman u-boot-sunxi-with-spl.bin is broken. Nowhere in the commit message you state that you want to run binman on sunxi boards. Best regards Heinrich
