Hi Prafulla, Le 05/08/2010 21:09, Prafulla Wadaskar a écrit : > > >> -----Original Message----- >> From: u-boot-boun...@lists.denx.de >> [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Albert Aribaud >> Sent: Thursday, August 05, 2010 6:06 PM >> To: u-boot@lists.denx.de >> Subject: [U-Boot] [PATCH V7 2/4] ide: add mvsata_ide driver >> >> This driver only provides initialization code; actual driving >> is done by cmd_ide.c using the ATA compatibility mode of the >> Marvell SATAHC controller. >> >> Signed-off-by: Albert Aribaud<albert.arib...@free.fr> >> --- >> drivers/block/Makefile | 7 +- >> drivers/block/mvsata_ide.c | 140 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 144 insertions(+), 3 deletions(-) >> create mode 100644 drivers/block/mvsata_ide.c >> >> diff --git a/drivers/block/Makefile b/drivers/block/Makefile >> index 3f6ad5c..64dcf4e 100644 >> --- a/drivers/block/Makefile >> +++ b/drivers/block/Makefile >> @@ -25,15 +25,16 @@ include $(TOPDIR)/config.mk >> >> LIB := $(obj)libblock.a >> >> +COBJS-$(CONFIG_SCSI_AHCI) += ahci.o >> COBJS-$(CONFIG_ATA_PIIX) += ata_piix.o >> -COBJS-$(CONFIG_CMD_MG_DISK) += mg_disk.o >> COBJS-$(CONFIG_FSL_SATA) += fsl_sata.o >> -COBJS-$(CONFIG_IDE_SIL680) += sil680.o >> COBJS-$(CONFIG_LIBATA) += libata.o >> +COBJS-$(CONFIG_CMD_MG_DISK) += mg_disk.o >> +COBJS-$(CONFIG_MVSATA_IDE) += mvsata_ide.o >> COBJS-$(CONFIG_PATA_BFIN) += pata_bfin.o >> COBJS-$(CONFIG_SATA_DWC) += sata_dwc.o >> COBJS-$(CONFIG_SATA_SIL3114) += sata_sil3114.o >> -COBJS-$(CONFIG_SCSI_AHCI) += ahci.o >> +COBJS-$(CONFIG_IDE_SIL680) += sil680.o >> COBJS-$(CONFIG_SCSI_SYM53C8XX) += sym53c8xx.o >> COBJS-$(CONFIG_SYSTEMACE) += systemace.o > > Hi Albert > You have merged two changes here, > 1. reordering the entire Makefile which is good thing, but irrelevant here > (could be separate patch). > 2. mvsata support updates, which is only relevant to the patch subject here. > > Otherwise, ack for rest of the code
The reordering was asked for in a previous review round. > Regards.. > Prafulla . . Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
