Dear Rogan Dawes, In message <4c5ab1a4.3000...@dawes.za.net> you wrote: > This may be a stupid comment, but from my perspective implementing > Albert's orion5x changes for my DNS323, all I am doing is copying a lot > of what Albert is doing for the edminiv2 verbatim. > > Would it not make sense perhaps to define defaults in a SoC config file, > and then allow them to be overridden as required for each specific board?
That would make sense, but quite often you don't know what will be common code and what not when writing the first version of such code. I recommend that you discuss with Albert (as part of the review process here) what should be handled as common driver code that you can easily reuse. It is pretty likely that your copied code would not be accepted for mainline, and you will be requested to factor out common parts when you submit it (that's quite often the fate for the second or third in such a row). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A rolling stone gathers momentum. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
