Hi Rick, On Thu, Oct 31, 2019 at 10:53 AM Rick Chen <rickche...@gmail.com> wrote: > > Hi Bin > > > > > Hi Rick, > > > > On Fri, Oct 25, 2019 at 2:18 PM Andes <ub...@andestech.com> wrote: > > > > > > From: Rick Chen <r...@andestech.com> > > > > > > When ax25-ae350 try to enable v5l2 cache > > > driver in SPL configuration, it need this > > > option for cache support in SPL. > > > > > > Signed-off-by: Rick Chen <r...@andestech.com> > > > Cc: KC Lin <kc...@andestech.com> > > > Cc: Alan Kao <alan...@andestech.com> > > > --- > > > common/spl/Kconfig | 7 +++++++ > > > drivers/Makefile | 1 + > > > 2 files changed, 8 insertions(+) > > > > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > > > index 86d7edf..4c4023a 100644 > > > --- a/common/spl/Kconfig > > > +++ b/common/spl/Kconfig > > > @@ -456,6 +456,13 @@ config SPL_CRYPTO_SUPPORT > > > this option to build the drivers in drivers/crypto as part of an > > > SPL build. > > > > > > +config SPL_CACHE_SUPPORT > > > > nits: please insert this option per alphabetical order, so it should > > come before SPL_CPU > > OK > > > > > > + bool "Support CACHE drivers" > > > + help > > > + Enable CACHE drivers in SPL. These drivers can store data so > > > that > > > + future requests for that data can be served faster. Enable this > > > option > > > > The description here "store data so that ..." does not apply to cache > > drivers > > Do you have any suggestions about how to describe it more precisely ? >
The descriptions says drivers can store data, but cache driver does not store data at all. I think you enabled it just for boot time performance? Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
