Dear Ilya Yanok,
In message <4c1f5a54.4050...@emcraft.com> you wrote:
>
> > Entry to MAINTAINERS missing.
>
> Should I add you as a maintainer or myself?
You did the actual work...
> >> +int board_eth_init(bd_t *bis)
> >> +{
> >> + cpu_eth_init(bis); /* Initialize TSECs first */
> >>
> > I think it's wrong to ignore the return code here.
>
> What makes you think so? What can we do with the return code here? Print
> warning? If we return error from board_eth_init() calling code will call
> cpu_eth_init() again which is useless as we have already called it.
> >> + return pci_eth_init(bis);
My understanding is that pci_eth_init() and board_eth_init() return
the number of NIC's found - should that number not include the number
of successfully initialized TSECs?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The use of COBOL cripples the mind; its teaching should, therefore,
be regarded as a criminal offence.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
