On Wed, Apr 21, 2010 at 01:24:36PM +0530, Vipin KUMAR wrote:
> +#if defined(CONFIG_BOARD_NAND_LP)
CONFIG_SYS_FSMC_NAND_LP, CONFIG_SYS_FSMC_NAND_16BIT, etc.
> + /*
> + * length is intentionally kept a higher multiple of 2
> + * to read at least 13 bytes even in case of 16 bit NAND
> + * devices
> + */
> + len = ((len + 1) >> 1) << 1;
len = roundup(len, 2);
> + fsmc_version = (peripid2 >> FSMC_REVISION_SHFT) & \
> + FSMC_REVISION_MSK;
Unnecessary backslash.
> +#ifndef __FSMC_NAND_H__
> +#define __FSMC_NAND_H__
> +
> +struct fsmc_regs {
> + u8 reserved_1[0x40];
> + u32 genmemctrl_pc; /* 0x40 */
> + u32 genmemctrl_sts; /* 0x44 */
> + u32 genmemctrl_comm; /* 0x48 */
> + u32 genmemctrl_attrib; /* 0x4c */
> + u32 genmemctrl_ioata; /* 0x50 */
> + u32 genmemctrl_ecc1; /* 0x54 */
> + u32 genmemctrl_ecc2; /* 0x58 */
> + u32 genmemctrl_ecc3; /* 0x5c */
> + u8 reserved_2[0xfe0 - 0x60];
> + u32 genmemctrl_peripid0; /* 0xfe0 */
> + u32 genmemctrl_peripid1; /* 0xfe4 */
> + u32 genmemctrl_peripid2; /* 0xfe8 */
> + u32 genmemctrl_peripid3; /* 0xfec */
> + u32 genmemctrl_pcellid0; /* 0xff0 */
> + u32 genmemctrl_pcellid1; /* 0xff4 */
> + u32 genmemctrl_pcellid2; /* 0xff8 */
> + u32 genmemctrl_pcellid3; /* 0xffc */
> +};
Is the genmemctrl_ prefix really needed?
> +extern int spear_nand_init(struct nand_chip *nand);
fsmc_nand_init?
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
