On 4/21/2010 5:41 PM, Peter Tyser wrote: > Hi Vipin, > > On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote: >> The i2c IP used by spear platform is a synopsys i2c controller >> The earlier driver adds the driver of this controller as if it is >> specific to >> spear platform. >> The driver files are now moved into drivers/i2c folder for reusability >> by other >> platforms >> >> Signed-off-by: Vipin Kumar <vipin.ku...@st.com> >> --- >> arch/arm/include/asm/arch-spear/spr_i2c.h | 146 ------------- >> drivers/i2c/Makefile | 2 +- >> drivers/i2c/dw_i2c.c | 331 >> +++++++++++++++++++++++++++++ > > I'd similarly lean towards naming the new file designware.c, or > synopsis.c. It looks like the rest of the i2c drivers use a _i2c > suffix, so I guess designware_i2c.c or synopsis_i2c.c would be best for > consistency's sake. At a minimum it'd be nice to mention in the > dw_i2c.c file what silicon the driver supports as right now a user needs > to guess what "dw_i2c.c" runs on based solely on "dw". >
OK, that's a good suggestion. I would change the name to designware_i2c.c and also include a little description about the manufacturer in the source header > When you create patches with git format-patch, its nice to use the -M > and -C to detect renames/copies. It makes the patch much smaller and > much easier to review what actually changed. > OK, I would generate the patch v2 with these options enabled Thanks for suggesting. Please find the changes in next version patch-set > Best, > Peter > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
