Hi Marek, > On 1/2/19 12:37 AM, Lukasz Majewski wrote: > > This is a cosmetic change, just to use proper define. > > > > Signed-off-by: Lukasz Majewski <lu...@denx.de> > > The subject tags are wrong, fix globally.
Is there any doc which describes the allowed/not allowed tags (either with Linux or U-boot)? From my experience it is a some kind of a convention depending on the maintainer (which helps him to spot relevant patches on ML). In [1] - point 14) there is: The canonical patch subject line is: "Subject: [PATCH 001/123] subsystem: summary phrase" and the "subsystem: " is the tag. In the case of this patch -> I do fix stuff in "board(s)" which is "cosmetic". Or will we only stick to tags/mails from ./doc/git-mailrc ? [1] - https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > > > --- > > > > board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c > > b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c index > > ace986fa05..bcc22b1aa8 100644 --- > > a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c +++ > > b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c @@ -118,7 +118,8 @@ static > > int setup_fec_clock(void) struct iomuxc *iomuxc_regs = (struct > > iomuxc *)IOMUXC_BASE_ADDR; > > /* set gpr1[21] to select anatop clock */ > > - clrsetbits_le32(&iomuxc_regs->gpr[1], 0x1 << 21, 0x1 << > > 21); > > + clrsetbits_le32(&iomuxc_regs->gpr[1], > > IOMUXC_GPR1_ENET_CLK_SEL_MASK, > > + IOMUXC_GPR1_ENET_CLK_SEL_MASK); > > > > return enable_fec_anatop_clock(0, ENET_50MHZ); > > } > > > > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgp8ptG_wd2Ua.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
