On 28/11/18 15:57, Peng Fan wrote: > Jon, > >> -----Original Message----- >> From: Jon Nettleton [mailto:j...@solid-run.com] >> Sent: 2018年11月28日 22:46 >> To: Fabio Estevam <feste...@gmail.com> >> Cc: Peng Fan <peng....@nxp.com>; Fabio Estevam >> <fabio.este...@nxp.com>; U-Boot Mailing List <u-boot@lists.denx.de>; >> dl-linux-imx <linux-...@nxp.com> >> Subject: Re: [U-Boot] [PATCH V2 14/15] drivers: ddr: introduce DDR driver for >> i.MX8M >> >> On Wed, Nov 21, 2018 at 1:40 PM Fabio Estevam <feste...@gmail.com> >> wrote: >>> >>> Hi Peng, >>> >>> On Wed, Nov 21, 2018 at 12:54 AM Peng Fan <peng....@nxp.com> wrote: >>> >>>> Stefano, Fabio, how about creating a follow up patch to remove the >> unused macros, or do you expect to create a v3 patchset for this removing? >>> >>> It is fine for me if you send a follow up patch removing them. >>> >>> Thanks >>> _______________________________________________ >>> U-Boot mailing list >>> U-Boot@lists.denx.de >>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis >>> >> ts.denx.de%2Flistinfo%2Fu-boot&data=02%7C01%7Cpeng.fan%40nxp.c >> om%7 >>> >> Cc5ac7e5f29394549d24008d655404621%7C686ea1d3bc2b4c6fa92cd99c5c3 >> 01635%7 >>> >> C0%7C1%7C636790131884926464&sdata=0JOZT0tgLDCbEQHlDGRY7R7 >> GpI66enbD >>> 6HvRieujt%2FU%3D&reserved=0 >> >> Peng, >> >> I have found one more piece that is missing from the lpddr4 initialization. >> We don't have a structure, or place to change the DDR PHY DQ lane to >> memory mapping registers. Our board requires this and was failing until I >> patched it in. >> >> According to the code generated from DDR tool this should happen after >> /* step7 [0]--1: disable quasi-dynamic programming */ > > Would you mind submit a follow up patch? > > Stefano, > > I'll submit a follow up patch to remove the unused macros in this patch, are > you ok with that? >
It is ok for me, thanks ! Regards, Stefano > Thanks, > Peng. > >> >> -Jon -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
