On 10/19/2018 02:47 PM, Alexander Graf wrote: > > > On 19.10.18 14:45, Marek Vasut wrote: >> On 10/19/2018 02:43 PM, Alexander Graf wrote: >>> The USB storage driver does not compile when CONFIG_BLK is set, >>> but DM_USB is not set, as we're missing the DM device links for >>> CONFIG_BLK enabled code paths. >>> >>> So far it looks like nobody fell into this trap, because no board >>> enabled CONFIG_BLK and CONFIG_USB_STORAGE while not enabling >>> CONFIG_DM_USB, but we should still reflect that dependency properly >>> in Kconfig so that implicit enabling of CONFIG_USB_STORAGE works. >>> >>> Signed-off-by: Alexander Graf <ag...@suse.de> >> >> Can we fix it such that it'd compile ? :) > > I'm not sure. It feels awkward to allow code to use DM enabled block > functions, but not DM enabled USB functionality. I can definitely see > why the code tripped over :). > > Wasn't Simon planning to rip out non-DM enabled devices soon'ish anyways?
I dunno. Which devices have this problem ? -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
