On 10/19/2018 02:43 PM, Alexander Graf wrote: > The USB storage driver does not compile when CONFIG_BLK is set, > but DM_USB is not set, as we're missing the DM device links for > CONFIG_BLK enabled code paths. > > So far it looks like nobody fell into this trap, because no board > enabled CONFIG_BLK and CONFIG_USB_STORAGE while not enabling > CONFIG_DM_USB, but we should still reflect that dependency properly > in Kconfig so that implicit enabling of CONFIG_USB_STORAGE works. > > Signed-off-by: Alexander Graf <ag...@suse.de>
Can we fix it such that it'd compile ? :) > --- > drivers/usb/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 4fbe172e05..297dda1511 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -65,6 +65,7 @@ comment "USB peripherals" > > config USB_STORAGE > bool "USB Mass Storage support" > + depends on DM_USB || !BLK > ---help--- > Say Y here if you want to connect USB mass storage devices to your > board's USB port. > -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
