On Sat, Feb 10, 2018 at 01:45:16AM +0100, Lukasz Majewski wrote: > Hi Jonathan, > > > On Sat, Feb 03, 2018 at 11:00:35AM -0200, Fabio Estevam wrote: > > > On Sat, Feb 3, 2018 at 5:29 AM, Lukasz Majewski <lu...@denx.de> > > > wrote: > > > > The goal of this patch is to clean up the code related to > > > > choosing SPL MMC boot mode. > > > > > > > > The spl_boot_mode() now is called only in spl_mmc_load_image() > > > > function, which is only compiled in if CONFIG_SPL_MMC_SUPPORT is > > > > enabled. > > > > > > > > To achieve the goal, all per mach/arch implementations eligible > > > > for unification has been replaced with one __weak implementation. > > > > > > > > Signed-off-by: Lukasz Majewski <lu...@denx.de> > > > > Reviewed-by: Marek Vasut <ma...@denx.de> > > > > Reviewed-by: Stefano Babic <sba...@denx.de> > > > > Acked-by: Michal Simek <michal.si...@xilinx.com> (For ZynqMP) > > > > > > Nice cleanup: > > > > > > Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> > > > > This has broken booting via mmc with mx6cuboxi for me. > > > > SPL loops on > > > > U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33 > > +1300) Trying to boot from MMC1 > > Failed to mount ext2 filesystem... > > spl_load_image_ext: ext4fs mount err - 0 > > Could you check what is the status of following defines in your .config > file: > > CONFIG_SPL_FAT_SUPPORT > CONFIG_SUPPORT_EMMC_BOOT
"# CONFIG_SPL_FAT_SUPPORT is not set" CONFIG_SUPPORT_EMMC_BOOT is not in the .config at all CONFIG_SPL_EXT_SUPPORT previously for imx6 would result in MMCSD_MODE_RAW but now it results in MMCSD_MODE_FS. > > And if by any chance your don't have: > CONFIG_SPL_EXT_SUPPORT defined? CONFIG_SPL_EXT_SUPPORT=y CONFIG_SPL_MMC_SUPPORT=y mx6cuboxi_defconfig with no changes > > From what you have written above I assume that you boot from the > same medium - i.e. eMMC (so SPL and u-boot.img are on the same medium) ? Both SPL and u-boot.img are on a microsd card. The set CONFIG_SPL_* in .config are CONFIG_SPL_SYS_THUMB_BUILD=y CONFIG_SPL_USE_ARCH_MEMCPY=y CONFIG_SPL_USE_ARCH_MEMSET=y CONFIG_SPL_LDSCRIPT="arch/arm/mach-omap2/u-boot-spl.lds" CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_SPL_MMC_SUPPORT=y CONFIG_SPL_SERIAL_SUPPORT=y CONFIG_SPL_LIBDISK_SUPPORT=y CONFIG_SPL_WATCHDOG_SUPPORT=y CONFIG_SPL_SYS_MALLOC_F_LEN=0x400 CONFIG_SPL_BOOTSTAGE_RECORD_COUNT=5 CONFIG_SPL_LOGLEVEL=4 CONFIG_SPL=y CONFIG_SPL_LEGACY_IMAGE_SUPPORT=y CONFIG_SPL_EXT_SUPPORT=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DOS_PARTITION=y CONFIG_SPL_ISO_PARTITION=y CONFIG_SPL_EFI_PARTITION=y _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
