Dear Alessandro Rubini,
In message <109a8c9f77c98641a8a02c4346cd2c7d2cc6794f.1255086085.git.rubini@
unipv.it> you wrote:
> From: Alessandro Rubini <rub...@unipv.it>
...
> +void lcd_enable(void)
> +{
> + printf("%s:%s\n", __FILE__, __func__);
> + int i;
Please no declarations in the middle of code.
And probably this should be debug() instead of printf() ?
> +int nhk8815_backlight_on(void)
> +{
> + printf("%s:%s\n", __FILE__, __func__);
> + int i;
Ditto, 2x.
> diff --git a/board/st/nhk8815/nhk8815.c b/board/st/nhk8815/nhk8815.c
> index efeb0d2..ded7681 100644
> --- a/board/st/nhk8815/nhk8815.c
> +++ b/board/st/nhk8815/nhk8815.c
> @@ -107,6 +107,7 @@ int board_eth_init(bd_t *bis)
> #endif
>
> extern int nhk8815_keypad_init(void); /* ./keypad.c */
> +extern int nhk8815_backlight_on(void); /* in ./lcd.c */
Please move prototype decl;arations to some header file.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"There's only one kind of woman ..." "Or man, for that matter. You
either believe in yourself or you don't."
-- Kirk and Harry Mudd, "Mudd's Women", stardate 1330.1
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
