Thiago A. Corrêa <thiago.cor...@gmail.com> wrote on 19/11/2009 16:41:05:
>
> Hi,
>
> On Thu, Nov 19, 2009 at 10:44 AM, Joakim Tjernlund
> <joakim.tjernl...@transmode.se> wrote:
> >
> > +#define tole(x) cpu_to_le32(x)
> > +
>
> This define is only used once and at the constants table, after that,
> cpu_to_le32 is called directly. Perhaps this could be removed and
> cpu_to_le32 used instead, or change everything at that file to tole().
> Two "symbols" to do the same thing doesn't seem right.
>
> Personally I think cpu_to_le32 is more readable, at the expense of a
> few more keyboard strokes.
The whole point of the tole define is to make the table more
readable. Try and replace tole in the table and then
look at it.
Jocke
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
