Wolfgang Denk wrote: > Dear Tom, > > In message <4ae99f40.4000...@windriver.com> you wrote: >>> By the way, the AT91RM9200.h. has hundreds of style problems. >>> This requires a complete revision of the AT91RM9200.h. >>> I can try this, but will take a while and I can't test other >>> RM9200 boards. >> Please limit your changes to what you can test. >> Tom > > Pure coding style changes are easy to verify - they should lead to > identical (except for the time stamps) images. > > Also, board maintainers can and should be challenged to test such > patches. > > Please don't stop improving the code just because others need to help > with the testing.
I was thinking that this would be converting from #define offsets to structures. It can be easy to get these wrong. Without testing as-you-go these types of bugs can be difficult to resolve. Tom > > Best regards, > > Wolfgang Denk > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot