On Thu, Apr 6, 2017 at 10:10 PM, Dinh Nguyen <dinh.li...@gmail.com> wrote: > On Wed, Apr 5, 2017 at 4:32 AM, Ley Foon Tan <ley.foon....@intel.com> wrote: >> Add i2c, timer and other A10 macros. >> >> Signed-off-by: Ley Foon Tan <ley.foon....@intel.com> >> --- >> arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h >> b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h >> index a7056d4..448fbdc 100644 >> --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h >> +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (C) 2014 Altera Corporation <www.altera.com> >> + * Copyright (C) 2014-2017 Altera Corporation <www.altera.com> >> * >> * SPDX-License-Identifier: GPL-2.0+ >> */ >> @@ -29,14 +29,20 @@ >> #define SOCFPGA_MPUL2_ADDRESS 0xfffff000 >> #define SOCFPGA_I2C0_ADDRESS 0xffc02200 >> #define SOCFPGA_I2C1_ADDRESS 0xffc02300 >> +#define SOCFPGA_I2C2_ADDRESS 0xffc02400 >> +#define SOCFPGA_I2C3_ADDRESS 0xffc02500 >> +#define SOCFPGA_I2C4_ADDRESS 0xffc02600 > > I made this comment in V3, and I'll make it again. Do we need to add > these when we can use DTS for the I2C driver? > We haven't enable CONFIG_DM_I2C for i2c in this patch series, so it still using older device model and these macros are still required in socfpga_common.h (#define CONFIG_SYS_I2C_BASE SOCFPGA_I2C0_ADDRESS).
Regards Ley Foon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
