On Thursday 24 November 2016 07:06 PM, Sekhar Nori wrote:
> USB1 is not used on AM57xx GP EVM in device mode.
> Enabling DWC3 USB support for AM57xx EVM gives
> the following warnings:
>
> CC board/ti/am57xx/board.o
> ../board/ti/am57xx/board.c:448:27: warning: 'usb_otg_ss1' defined but not
> used [-Wunused-variable]
> static struct dwc3_device usb_otg_ss1 = {
> ^
> ../board/ti/am57xx/board.c:455:32: warning: 'usb_otg_ss1_glue' defined but
> not used [-Wunused-variable]
> static struct dwc3_omap_device usb_otg_ss1_glue = {
> ^
> ../board/ti/am57xx/board.c:461:33: warning: 'usb_phy1_device' defined but not
> used [-Wunused-variable]
> static struct ti_usb_phy_device usb_phy1_device = {
>
> Fix it by getting rid of USB1 related structures from
> board.c. They can be added back if there is a need for
> them.
>
> Signed-off-by: Sekhar Nori <nsek...@ti.com>
> Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com>
hmm.. Isn't this already taken care by commit ca39bd8ce1343 ("am57xx:
Remove unused variable warnings) ?
Thanks and regards,
Lokesh
> ---
> board/ti/am57xx/board.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
> index 64de60254136..f3e3f0bd3d60 100644
> --- a/board/ti/am57xx/board.c
> +++ b/board/ti/am57xx/board.c
> @@ -447,26 +447,6 @@ int spl_start_uboot(void)
> #endif
>
> #ifdef CONFIG_USB_DWC3
> -static struct dwc3_device usb_otg_ss1 = {
> - .maximum_speed = USB_SPEED_SUPER,
> - .base = DRA7_USB_OTG_SS1_BASE,
> - .tx_fifo_resize = false,
> - .index = 0,
> -};
> -
> -static struct dwc3_omap_device usb_otg_ss1_glue = {
> - .base = (void *)DRA7_USB_OTG_SS1_GLUE_BASE,
> - .utmi_mode = DWC3_OMAP_UTMI_MODE_SW,
> - .index = 0,
> -};
> -
> -static struct ti_usb_phy_device usb_phy1_device = {
> - .pll_ctrl_base = (void *)DRA7_USB3_PHY1_PLL_CTRL,
> - .usb2_phy_power = (void *)DRA7_USB2_PHY1_POWER,
> - .usb3_phy_power = (void *)DRA7_USB3_PHY1_POWER,
> - .index = 0,
> -};
> -
> static struct dwc3_device usb_otg_ss2 = {
> .maximum_speed = USB_SPEED_HIGH,
> .base = DRA7_USB_OTG_SS2_BASE,
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
