Olof Johansson wrote: > On Sep 23, 2009, at 7:34 PM, Nishanth Menon wrote: > >> Olof Johansson said the following on 09/23/2009 09:43 PM: >>> On Sep 23, 2009, at 1:39 PM, Tom wrote: >>> >>> >>>> Olof Johansson wrote: >>>> >>>>> diff --git a/board/overo/overo.c b/board/overo/overo.c >>>>> index dd6d286..7d87e52 100644 >>>>> --- a/board/overo/overo.c >>>>> +++ b/board/overo/overo.c >>>>> >>>>> + writel(GPIO0, &gpio3_base->cleardataout); >>>>> + udelay(1); >>>>> + writel(GPIO0, &gpio3_base->setdataout); >>>>> >>>> Use the omap gpio interface described in README.omap3 >>>> >>>> >>> >>> Seriously, this code is a 1:1 replica from the evm code. Obviously >>> that code was good enough to merge. >>> >> >> should'nt we be fixing evm code instead of moving similar code in for >> another platform? > > Sure, but you forgot to attach the patch. >
;) Yes the evm should be fixed but... I think Olof has had enough 'just one mores' .. The point is to get patch in. I will add the evm changes to my follow-on if there is someone to test the changes. Tom > > -Olof _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
