On Wed, Sep 28, 2016 at 2:30 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote: > On Thu, Sep 29, 2016 at 12:51 AM, Joe Hershberger > <joe.hershber...@gmail.com> wrote: >> On Wed, Sep 28, 2016 at 2:15 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote: >>> On Thu, Sep 29, 2016 at 12:41 AM, Joe Hershberger >>> <joe.hershber...@gmail.com> wrote: >>>> On Wed, Sep 28, 2016 at 1:28 PM, Jagan Teki <jt...@openedev.com> wrote: >>>>> From: Jagan Teki <ja...@amarulasolutions.com> >>>>> >>>>> Add enet support for engicam icorem6 qdl starter kit. >>>>> - Add pinmux settings >>>>> - Add board_eth_init >>>>> >>>>> TFTP log: >>>>> -------- >>>>> Net: FEC [PRIME] >>>>> Hit any key to stop autoboot: 0 >>>>> icorem6qdl> tftpboot {fdt_addr} imx6dl-icore.dtb >>>>> Using FEC device >>>>> TFTP from server 192.168.2.96; our IP address is 192.168.2.75 >>>>> Filename 'imx6dl-icore.dtb'. >>>>> Load address: 0x0 >>>>> Loading: ###### >>>>> 1.3 MiB/s >>>>> done >>>>> Bytes transferred = 28976 (7130 hex) >>>>> CACHE: Misaligned operation at range [00000000, 00007130] >>>>> icorem6qdl> >>>>> >>>>> Cc: Joe Hershberger <joe.hershber...@ni.com> >>>>> Cc: Peng Fan <peng....@nxp.com> >>>>> Cc: Stefano Babic <sba...@denx.de> >>>>> Cc: Fabio Estevam <fabio.este...@nxp.com> >>>>> Cc: Matteo Lisi <matteo.l...@engicam.com> >>>>> Cc: Michael Trimarchi <mich...@amarulasolutions.com> >>>>> Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> >>>>> --- >>>>> board/engicam/icorem6/icorem6.c | 72 >>>>> +++++++++++++++++++++++++++++++++++++ >>>>> configs/imx6qdl_icore_mmc_defconfig | 4 +++ >>>>> include/configs/imx6qdl_icore.h | 12 +++++++ >>>>> 3 files changed, 88 insertions(+) >>>>> >>>> >>>> ... >>>> >>>>> diff --git a/configs/imx6qdl_icore_mmc_defconfig >>>>> b/configs/imx6qdl_icore_mmc_defconfig >>>>> index a658f4b..d304693 100644 >>>>> --- a/configs/imx6qdl_icore_mmc_defconfig >>>>> +++ b/configs/imx6qdl_icore_mmc_defconfig >>>>> @@ -14,6 +14,8 @@ CONFIG_SYS_MAXARGS=32 >>>>> # CONFIG_CMD_IMLS is not set >>>>> CONFIG_CMD_BOOTZ=y >>>>> CONFIG_CMD_GPIO=y >>>>> +CONFIG_CMD_MII=y >>>>> +CONFIG_CMD_PING=y >>>>> CONFIG_CMD_MEMTEST=y >>>>> CONFIG_CMD_MMC=y >>>>> CONFIG_CMD_CACHE=y >>>>> @@ -23,5 +25,7 @@ CONFIG_CMD_EXT4_WRITE=y >>>>> CONFIG_CMD_FAT=y >>>>> CONFIG_CMD_FS_GENERIC=y >>>>> CONFIG_OF_LIBFDT=y >>>>> +CONFIG_FEC_MXC=y >>>>> CONFIG_MXC_UART=y >>>>> +CONFIG_NETDEVICES=y >>>>> CONFIG_IMX_THERMAL=y >>>> >>>> I guess this board can't use CONFIG_DM_ETH for some reason? >>> >>> True I will remove and send the patch. >> >> I assume you mean you'll switch the board to enable CONFIG_DM_ETH? Not >> sure what you mean when you say you will remove (something) when my >> comment was about the absence of a config. > > Sorry, I am not planning to use DM_ETH as of now. Since all net > drivers in Kconfig are in if CONFIG_NETDEVICES. ie the reason I added. > I think this is needed in defconfig.
CONFIG_NETDEVICES certainly is needed if you don't specify CONFIG_DM_ETH. I prefer new board support use DM_ETH. What's the reason for not using DM? Thanks, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot